feat: multi::many_till_count combinator #1790
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
many_till_countcombinator, as I proposed in #1594 - see that issue for more discussion.I've copied and adapted the tests relevant to
many_tillfor this new combinator - if that's not sufficient, I'm happy to add specialised tests for any edge cases we can think of.Closes #1594.
A general rationale for the combinator is that it's useful for those cases when the output of parser
finmany_tillis not important (eg. it's garbage data) or when theallocfeature is not enabled. The combinator follows the previous logic of being half of analloc/_countpair.